Skip to content

feat: (WIP) Support virtual focus for grid components #8728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 56 commits into
base: main
Choose a base branch
from
Draft

feat: (WIP) Support virtual focus for grid components #8728

wants to merge 56 commits into from

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Aug 14, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

LFDanLu added 30 commits June 26, 2025 17:01
@LFDanLu
account for loaders in base collection filter
c9ee11d
@LFDanLu
rough implementation for listbox
ac323e9
@LFDanLu
replace other instances of createLeaf/createBranch to use node classes
290514a
@LFDanLu
fix bugs with subdialog filtering, arrow nav, dividers, etc
2969511
@LFDanLu
fix case where arrow nav wasnt working post filter
d8a6f06
@LFDanLu
Merge branch 'main' of github.com:adobe/react-spectrum into baseColle…
639acd0 
…ction_filter
@LFDanLu
update types and class node structure
6eb1753
@LFDanLu
prep stories
d1efa8d
@LFDanLu
fix
77936ca
@LFDanLu
add autocomplete gridlist filtering
7991977
@LFDanLu
taglist filter support
e615835
@LFDanLu
fixing lint
d02197e
@LFDanLu
fix tag group keyboard nav and lint
361286b
@LFDanLu
adding support for table filtering
432a43c
@LFDanLu
fix tableCollection filter so it doesnt need to call filterChildren d…
3ec3fd6 
…irectly
@LFDanLu
create common use nodes for specific filtering patterns
4a69d50
@LFDanLu
fix ssr
73a1971
@LFDanLu
refactor to accept a node rather than a string in the filter function
1ead59b
@LFDanLu
fix lint
90c2056
@LFDanLu
make node param in autocomplete non breaking
3a8301e
@LFDanLu
Merge branch 'main' of github.com:adobe/react-spectrum into baseColle…
45a39c1 
…ction_filter
@LFDanLu
adding tests, make sure we only apply autocomplete attributes if the …
9d65d5b 
…wrapped collection is filterable
@LFDanLu
prevent breaking change in CollectionBuilder by still accepting strin…
19b695e 
…g for CollectionNodeClass
@LFDanLu
fix tests and pass submenutrigger node to filterFn
6066c6c
@LFDanLu
small clean up
d2b5e51
@LFDanLu
rough support for virtual focus taggroup
d49f6b2
@LFDanLu
rough support for virtualfocus gridlist
50bfc76
@LFDanLu
skip test for now for testing
3fe0ca2
@LFDanLu
skipping more tests for testing
6b3fcda
@LFDanLu
sigh lint
2d04f94
LFDanLu added 26 commits August 4, 2025 13:02
@LFDanLu
fix lint
d3f22fb
@LFDanLu
small fixes
2c89783
@LFDanLu
addressing more review comments
739e93f
@LFDanLu
simplifying setProps logic since we have already have id when calling it
3c2e92c
@LFDanLu
forgot to use generic for autocomplete filter
35b627e
@LFDanLu
ugh docs typescript
9408aa9
@LFDanLu
review comments
8e75339
@LFDanLu
autoimport....
c111744
@LFDanLu
replace internal autocomplete context
24dd7cb
@LFDanLu
add FieldInputContext in place of input context and search/textfield …
d8969a7 
…context in autocomplete
@LFDanLu
fix build
ae3cc84
@LFDanLu
removing erroneous autoimports
3a81f31
@LFDanLu
add ability for user to provide independent filter text
db91b3a
@LFDanLu
fix lint
7177106
@LFDanLu
fix some more tests
dfb80f3
@LFDanLu
bring back controlled input value at autocomplete level
ec8066f
@LFDanLu
adding prop to disable virtual focus
76107ff
@LFDanLu
another stab at the types
cde0977
@LFDanLu
clear autocomplete contexts so that they dont leak to nested collections
82cb364
@LFDanLu
add tests for disallowVirtualFocus works with listbox and menu
18d3dbc
@LFDanLu
add example testing the Autocomplete generic
57e57e0
@LFDanLu
Merge branch 'baseCollection_filter' of github.com:adobe/react-spectr…
549308f 
…um into support_grid_autocomplete
@LFDanLu
Merge branch 'autocomplete_context_refactor' of github.com:adobe/reac…
74d3bc0 
…t-spectrum into support_grid_autocomplete
@LFDanLu
override backspace so tag delete doesnt happen on delete
e269660
@LFDanLu
fix row to content focus cycling in GridList when using virtual focus
e6bb449 
previously ArrowLeft wasnt moving off the button when using virtual focus since the row isnt a focusable element from the focusable treewalker point of view. Can now be verfied via the aria activedescendat attribute
@LFDanLu
progress with supporting virtual focus in table
fb8d89e 
still a bunch of bugs, see notes
This was referenced Aug 15, 2025
Merged
Merged
Base automatically changed from autocomplete_context_refactor to baseCollection_filter August 18, 2025 18:09
Base automatically changed from baseCollection_filter to main August 20, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LFDanLu