fix: properly render empty state when filtering S2 ComboBox with sections #8735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
LFDanLu
commented
Aug 19, 2025
| @@ -27,7 +27,7 @@ const meta: Meta<typeof ComboBox<any>> = { | |||
| }, | |||
| tags: ['autodocs'], | |||
| argTypes: { | |||
| ...categorizeArgTypes('Events', ['onInputChange', 'onOpenChange', 'onSelectionChange']), | |||
| ...categorizeArgTypes('Events', ['onInputChange', 'onOpenChange', 'onSelectionChange', 'onLoadMore']), | |||
There was a problem hiding this comment.
didn't realize we had to do this for any action handlers due to storybook 8 making implicit actions error...
Comment on lines
+55
to
+60
| // Only count sections and items when determining size so that | ||
| // loaders and separators in RAC/S2 don't influence the emptyState determination | ||
| if (node.type === 'section' || node.type === 'item') { | ||
| size++; | ||
| } | ||
|
|
There was a problem hiding this comment.
this shouldn't affect v3 theoretically since there wasn't a concept of loader/separator nodes
snowystinger
approved these changes
Aug 20, 2025
|
Did you want any tests for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From testing
✅ Pull Request Checklist:
📝 Test Instructions:
Try filtering a S2 combobox that has sections and ensure that the empty state will appear properly.
🧢 Your Project:
RSP