Skip to content

Display N/A and Hang suspected in Duration column #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Aug 9, 2025

Improve TRSS duration display:

  • N/A -> no Start Time
  • Hang suspected -> has Start Time, but no Finish Time

related: runtimes/backlog/issues/1692

Copy link

netlify bot commented Aug 9, 2025

Deploy Preview for eclipsefdn-adoptium-trss canceled.

Name Link
🔨 Latest commit b6deac7
🔍 Latest deploy log https://app.netlify.com/projects/eclipsefdn-adoptium-trss/deploys/6899e6f66b81d90008ae6e4c

@llxia
Copy link
Contributor Author

llxia commented Aug 9, 2025

image

@llxia llxia requested a review from LongyuZhang August 9, 2025 02:18
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the purpose of Infinity?

@llxia
Copy link
Contributor Author

llxia commented Aug 10, 2025

When a test has a start time but no finish time, the test duration cannot be determined. Therefore, set duration to Infinity. This is to highlight a possible test hanging issue.

@smlambert
Copy link
Contributor

smlambert commented Aug 10, 2025

When a test has a start time but no finish time, the test duration cannot be determined.

There may be a better phrase to use for this then, as infinity is a provocative word. "Not determined", "Not determinable", "No finish time", "Hang suspected", "Undetermined", ... others?

@llxia
Copy link
Contributor Author

llxia commented Aug 11, 2025

updated to use Hang suspected if no finish time.

image

related: runtimes/backlog/issues/1692

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia llxia changed the title Display N/A and Infinity in Duration column Display N/A and Hang suspected in Duration column Aug 11, 2025
@llxia
Copy link
Contributor Author

llxia commented Aug 11, 2025

@karianna could you take a look again? Thanks

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 39c5a60 into adoptium:master Aug 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants