-
-
Notifications
You must be signed in to change notification settings - Fork 78
Enabled Suse RPMs to get built locally #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
@karianna, @gdams, @johnoliver, @d3r3kk, and anyone else on the adopt team: please give it a look when you can :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meta note: Not sure why we still have linux and linux_new
Meta note: I assume Suse 15.5 is the latest?
@jmjaffe37 Might be an issue with your signed commits WRT to having signed the Eclipse CLA. |
@karianna, there seems to be an issue with checking if I am validated. The link tells me that I both am and am not validated. When I click the button to revalidate, it asks me to do a captcha and then nothing happens |
I'd suggest for @steelhead31 to review this when he has some cycles as he's recently done the installer automation. I'm not very close to this code right now. |
@karianna we still have linux and linux_new, as we/I have still been shaking down the new automated process. The plan is to remove linux at some future point, though it appears others outside of temurin may depend on it... perhaps renaming linux_new to reflect its for the temurin package automation ? I'll take a look at this PR, and test it with the automation once the current release cycle is completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok, I've tested it with the automation processes and they continue to work as expected.
Please, can we hold off merging this until after the release, should be ok once code freeze is lifted. |
ECA now passes, just waiting on code freeze to lift. |
/thaw |
Pull Request unblocked - code freeze is over.
Changes tested internally by building MSFT openjdk. Changes made in both
linux
andlinux_new
folders