Skip to content

Enabled Suse RPMs to get built locally #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 29, 2025
Merged

Conversation

jmjaffe37
Copy link
Contributor

@jmjaffe37 jmjaffe37 commented Apr 21, 2025

Changes tested internally by building MSFT openjdk. Changes made in both linux and linux_new folders

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@jmjaffe37
Copy link
Contributor Author

jmjaffe37 commented Apr 21, 2025

@karianna, @gdams, @johnoliver, @d3r3kk, and anyone else on the adopt team: please give it a look when you can :)

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta note: Not sure why we still have linux and linux_new
Meta note: I assume Suse 15.5 is the latest?

@jmjaffe37 jmjaffe37 requested a review from karianna April 22, 2025 16:44
@jmjaffe37
Copy link
Contributor Author

@jerboaa, are you able to give me a review here as well? @karianna referred me to you :)

@karianna karianna requested a review from jerboaa April 23, 2025 22:37
@karianna
Copy link
Contributor

@jmjaffe37 Might be an issue with your signed commits WRT to having signed the Eclipse CLA.

@jmjaffe37
Copy link
Contributor Author

@karianna, there seems to be an issue with checking if I am validated. The link tells me that I both am and am not validated. When I click the button to revalidate, it asks me to do a captcha and then nothing happens

@jerboaa
Copy link
Contributor

jerboaa commented Apr 24, 2025

I'd suggest for @steelhead31 to review this when he has some cycles as he's recently done the installer automation. I'm not very close to this code right now.

@steelhead31
Copy link
Contributor

@karianna we still have linux and linux_new, as we/I have still been shaking down the new automated process. The plan is to remove linux at some future point, though it appears others outside of temurin may depend on it... perhaps renaming linux_new to reflect its for the temurin package automation ?

I'll take a look at this PR, and test it with the automation once the current release cycle is completed.

@steelhead31 steelhead31 self-requested a review April 24, 2025 09:35
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, I've tested it with the automation processes and they continue to work as expected.

@steelhead31
Copy link
Contributor

Please, can we hold off merging this until after the release, should be ok once code freeze is lifted.

@karianna
Copy link
Contributor

Please, can we hold off merging this until after the release, should be ok once code freeze is lifted.

ECA now passes, just waiting on code freeze to lift.

@steelhead31
Copy link
Contributor

/thaw

@github-actions github-actions bot dismissed their stale review April 29, 2025 08:33

Pull Request unblocked - code freeze is over.

@steelhead31 steelhead31 merged commit fcb9d5a into adoptium:master Apr 29, 2025
67 checks passed
@jmjaffe37 jmjaffe37 deleted the jmj/suse branch April 29, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants