Skip to content

Updated MSI creation code and documentation to wix v6 #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025

Conversation

jmjaffe37
Copy link
Contributor

@jmjaffe37 jmjaffe37 commented May 20, 2025

Tested with Microsoft's build of the OpenJDK

@jmjaffe37 jmjaffe37 changed the title Updated code and documentation to wix v6 Updated MSI creation code and documentation to wix v6 May 20, 2025
@jmjaffe37 jmjaffe37 marked this pull request as draft May 20, 2025 23:20
@jmjaffe37 jmjaffe37 marked this pull request as ready for review May 20, 2025 23:30
Copy link

@brianjstafford brianjstafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams
Copy link
Member

gdams commented May 26, 2025

Noting that we'll need to update wix installed on the machines again. @steelhead31 are you able to do this for us please?

@steelhead31
Copy link
Contributor

I'll put a PR in for the playbook changes, and get the windows machines updated appropriately.

@AdamBrousseau
Copy link
Contributor

Sorry for my ignorance here, but is there another PR or Issue with the details of why the bump from 5 to 6?

@jmjaffe37
Copy link
Contributor Author

@AdamBrousseau, we just want to make sure that our default tools are up to date! This also ensures that all PRs into this tool will comply with the latest standards. That said, the tool still works with wix v5.* at the moment, so our vendors can continue to use that for now if they choose (they can specify this in the command line)

@gdams
Copy link
Member

gdams commented May 30, 2025

@steelhead31 are the build machines all updated? Can we merge this now?

@steelhead31
Copy link
Contributor

@steelhead31 are the build machines all updated? Can we merge this now?

@gdams yes, the one build machine that handles building windows installers is updated, the windows docker build images haven't been updated, but as these arent used for building the msi's it shouldn't matter.

@gdams gdams merged commit 1040e9e into adoptium:master Jun 2, 2025
11 checks passed
@jmjaffe37 jmjaffe37 deleted the jmj/wix_v6 branch June 2, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants