-
-
Notifications
You must be signed in to change notification settings - Fork 78
Updated MSI creation code and documentation to wix v6 #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Noting that we'll need to update wix installed on the machines again. @steelhead31 are you able to do this for us please? |
I'll put a PR in for the playbook changes, and get the windows machines updated appropriately. |
Sorry for my ignorance here, but is there another PR or Issue with the details of why the bump from 5 to 6? |
@AdamBrousseau, we just want to make sure that our default tools are up to date! This also ensures that all PRs into this tool will comply with the latest standards. That said, the tool still works with |
@steelhead31 are the build machines all updated? Can we merge this now? |
@gdams yes, the one build machine that handles building windows installers is updated, the windows docker build images haven't been updated, but as these arent used for building the msi's it shouldn't matter. |
Tested with Microsoft's build of the OpenJDK