-
-
Notifications
You must be signed in to change notification settings - Fork 78
Specify a custom container registry #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
7aba7e9
Use defined images
Luigi96 7f39d84
Add container registry property
Luigi96 30f7e77
Fix mispell of buildArgs
Luigi96 d9ee331
Try simpifing buildArgs
Luigi96 154f67c
Fix build arg
Luigi96 f35393f
Print container registry and build args
Luigi96 53aa384
Use container registry arg in gosu
Luigi96 6498a0e
Set container registry without build-args
Luigi96 0ada1d6
Fix adding build arguments
Luigi96 58a9e83
Add container registry argument to dockerfiles and docker build cmds
Luigi96 c1b65d3
Add container registry property to RedHat tests
Luigi96 214cb4d
Print container registry
Luigi96 0f608fc
Use environment variable to set registry
Luigi96 033aaea
Debug container registry
Luigi96 ede4f8a
Print container registry on gradle for debug
Luigi96 2e01b35
Add container registry option to all distros
Luigi96 6922459
Fix container registry for debian Dockerfile
Luigi96 b3b5004
Fix bug when container registry wasn't set
Luigi96 a3ba961
Fix missing semicolons
Luigi96 6a85e4e
Fix issue to send container registry when testing
Luigi96 4049cec
Print docker.io as default container registry
Luigi96 23571e9
Add just CONTAINER_REGISTRY as build argument
Luigi96 5063d19
Merge branch 'master' into user-defined-image
Luigi96 ef617ed
Fix identation issues
Luigi96 ef7c006
Check if container registry is not null or empty string
Luigi96 2d37877
Fix image order
Luigi96 9b399d5
Merge branch 'master' into user-defined-image
Luigi96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
FROM alpine | ||
ARG CONTAINER_REGISTRY="" | ||
|
||
FROM ${CONTAINER_REGISTRY}alpine | ||
ENV GOSU_VERSION 1.14 | ||
|
||
RUN set -eux; \ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.