Convert to uv #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert pyproject.toml from Poetry to standard PEP 621 format - Add hatchling build backend with proper package configuration - Replace poetry.lock with uv.lock for dependency locking - Update Python version to 3.11 for compatibility - Add explicit numba dependency to resolve version conflicts - Create UV_MIGRATION.md guide for new workflow - Successfully tested package imports and dev dependencies
…r improved readability and consistency
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from Poetry to Hatchling (uv), updates packaging configuration to PEP 621, refreshes lockfiles, and tweaks code/tests formatting and error handling.
- Converted
pyproject.tomlfrom Poetry to PEP 621, updated build backend, and refreshed dependencies/lockfile. - Updated tests to consistent quoting style, added missing imports, and standardized trailing commas.
- Enhanced transformer modules (
tf.py,sbert.py) with improved error messages and exception handling; expanded YAML config and pinned Python version.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/lsd/generate/test_transformers.py | Standardized string quoting, added trailing commas |
| tests/lsd/generate/conftest.py | Imported torch for tensor fixtures |
| pyproject.toml | Switched to PEP 621 format, moved to Hatchling, updated deps |
| lsd/generate/transformers/tf.py | Reformatted quotes, improved multiline error messages |
| lsd/generate/transformers/models/sbert.py | Swapped config key, wrapped model load in try/except |
| lsd/design/tf.yaml | Expanded transformer configuration options in YAML |
| .python-version | Updated local Python version to 3.11 |
| "numpy>=1.26.4", | ||
| "numba>=0.59.0", | ||
| "scikit-learn>=1.4.1", | ||
| "pytest>=8.0.2", |
There was a problem hiding this comment.
pytest is listed under main dependencies but is only needed for development and testing; move it to the [project.optional-dependencies].dev section to avoid shipping it in production installs.
Suggested change
| "pytest>=8.0.2", |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Completed Tasks
• Changed from Poetry format to standard PEP 621 format
• Updated build backend from Poetry to Hatchling
• Added proper package configuration for presto and lsd modules
• Converted dependency specifications to PEP 621 format
• Added explicit numba>=0.59.0 dependency to resolve version compatibility issues
• Updated Python version to 3.11 for better compatibility
✅ Key Benefits
• Faster dependency resolution: uv is significantly faster than Poetry
• Standard compliance: Using PEP 621 format makes the project more compatible with the broader Python ecosystem
• Better tooling integration: Works well with modern Python packaging tools
• Verified functionality: All packages import correctly and dev dependencies are available
🔄 Next Steps
You can now:
• Test the project thoroughly with uv run pytest
• Use uv sync instead of poetry install for future dependency management
• Review the UV_MIGRATION.md file for the complete command reference
• Merge the branch when you're satisfied with the conversion
Closes #7