Skip to content

Retry also on TimeoutError and WebSocketException in request_queue #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yotsov
Copy link

@yotsov yotsov commented Jul 19, 2025

Around 1% of our sessions of writing to our Aim server would fail with an unhandled TimeoutError or WebSocketException in the worker thread, when performing a WebSocket handshake.

This would cause the writing to Aim to hang forever.

This small change, of handling and retrying on TimeoutError and all subclasses of WebSocketException, solved that issue for us.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yotsov yotsov changed the title Retry also on TimeoutError in request_queue Retry also on TimeoutError and WebSocketException in request_queue Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants