Skip to content

Update CMakeLists.txt #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

Update CMakeLists.txt #33

merged 1 commit into from
Mar 28, 2025

Conversation

mosfet80
Copy link

allign cmake version.
Also fix cmake deprecation warning.

@mosfet80
Update CMakeLists.txt
fcb18ab 
allign cmake version.
Also fix cmake deprecation warning.


Signed-off-by: mosfet80 <realeandrea@yahoo.it>
@christophebedard
Copy link
Member

This is almost the same as #32. Which PR is valid?

@mosfet80 mosfet80 mentioned this pull request Mar 28, 2025
Closed
@mosfet80
Copy link
Author

This is almost the same as #32. Which PR is valid?
#32 closed

google mock use cmake 3.15
https://github.com/ament/googletest/blob/rolling/googlemock/CMakeLists.txt

@christophebedard
Copy link
Member

I think the comment from #31 (review) is still valid: there's nothing wrong with this change, but it doesn't really change anything. This is the CMakeLists.txt file that gets used to build googletest, and it still uses CMake >=3.8: https://github.com/ament/googletest/blob/rolling/googletest/CMakeLists.txt.install.

@christophebedard
Copy link
Member

Pulls: #33
Gist: https://gist.githubusercontent.com/christophebedard/78d468e602867d60d90143759942a3fa/raw/6d62f1e77d2a898c97333bfae8abfecfc127a3d9/ros2.repos
BUILD args: --packages-above-and-dependencies gtest_vendor
TEST args: --packages-above gtest_vendor
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15518

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

christophebedard
christophebedard approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows test failure is definitely unrelated.

@christophebedard christophebedard merged commit 699989e into ament:rolling Mar 28, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosfet80 @christophebedard