Apms by region request #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-falda
commented
Jun 27, 2025
| @@ -7,6 +7,7 @@ | |||
| public function __construct( | |||
| public string $id, | |||
| public string $type, | |||
| public string $state, | |||
There was a problem hiding this comment.
there is some state like "boxnow-ready"
|
|
||
| public function getHeaders(): array | ||
| { | ||
| return []; |
There was a problem hiding this comment.
no authorization required for this, but I'll confirm that
| @@ -25,6 +25,7 @@ public function handleData(array $data): void | |||
| $this->pickupPoints[] = new PickupPointDTO( | |||
| $pickupPoint['id'], | |||
| $pickupPoint['state'], | |||
There was a problem hiding this comment.
in this response there is no type, only state.
Previously as "type" we set "state" so i left it as is
lukasz-falda
force-pushed
the
apms-by-region
branch
2 times, most recently
from
8d7e76f to
7f7772b
Compare
lukasz-falda
force-pushed
the
apms-by-region
branch
from
7f7772b to
8c445f6
Compare
yekovalenkoa
approved these changes
Jun 27, 2025
|
|
||
| public function getEndpoint(): string | ||
| { | ||
| return str_replace('REGION_PLACEHOLDER', $this->region->value, self::ENDPOINT); |
There was a problem hiding this comment.
a placeholder is better to show what exactly I'm doing
jrawska
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.