Apollo 4 Migration #98
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...aven-plugin/src/main/kotlin/com/github/aoudiamoncef/apollo/plugin/util/UnsafeOkHttpClient.kt
Dismissed
Show dismissed
Hide dismissed
...aven-plugin/src/main/kotlin/com/github/aoudiamoncef/apollo/plugin/util/UnsafeOkHttpClient.kt
Dismissed
Show dismissed
Hide dismissed
|
Additional Information: |
|
Thanks for your contribution. Try to split PR into small tasks Don't worry about formatting,I'll do with It. |
|
Hi @aoudiamoncef, Can you elaborate on that? |
|
Any news on this? At least the code generation looks good. |
|
Haven't heard back from @aoudiamoncef yet 🙂 |
|
Hi @aoudiamoncef any plans to merge this? |
| @@ -130,24 +125,52 @@ object ConfigUtils { | |||
| compilerParams.schemaPackageName = "${project.groupId}.apollo.client.${service.compilationUnit.name}.schema" | |||
| } | |||
|
|
|||
| if (compilerParams.targetLanguage == TargetLanguage.JAVA) { | |||
There was a problem hiding this comment.
Display warnings is more appropriate here.
| executableFiles = graphqlFiles.toInputFiles(), | ||
| irOptions = irOptions, | ||
| codegenOptions = codegenOptions, | ||
| layoutFactory = null, // ToDo: plugin?.layout(codegenSchema) |
There was a problem hiding this comment.
IMHO, the easiest way is to let the user instanciate a classe like we did operationOutputGenerator
| @@ -159,13 +156,10 @@ | |||
| <generateAsInternal>false</generateAsInternal> | |||
| <generateFilterNotNull>false</generateFilterNotNull> | |||
| <generateFragmentImplementations>false</generateFragmentImplementations> | |||
| <generateResponseFields>false</generateResponseFields> | |||
| <generateQueryDocument>true</generateQueryDocument> | |||
There was a problem hiding this comment.
the goal is to show all params, just remove the old value to make it null
|
@aoudiamoncef thanks for the comments! |
POC Apollo 4 Migration
Initial Effort to implement #93.
Still missing (as far as I can tell):
Any feedback/help is appreciated.