[FLINK-37739][cli] fix flink-conf is not obtained in local mode #4006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOBIN-F
changed the title
joyCurry30
reviewed
Apr 29, 2025
Comment on lines
72
to
75
| public static FlinkPipelineComposer ofMiniCluster() { | ||
| return new FlinkPipelineComposer( | ||
| StreamExecutionEnvironment.getExecutionEnvironment(), true); | ||
| } |
There was a problem hiding this comment.
Is it still necessary to keep this method?
There was a problem hiding this comment.
There are still many test cases that use this method. Since they do not use flinkConf and additionalJars, I chose to keep this method.
joyCurry30
reviewed
Apr 29, 2025
Comment on lines
+273
to
+276
| @VisibleForTesting | ||
| public StreamExecutionEnvironment getEnv() { | ||
| return env; | ||
| } |
There was a problem hiding this comment.
Would it be possible to use Java reflection in the test to obtain this object, instead of creating a separate method for it?
There was a problem hiding this comment.
Reflection makes code difficult to maintain
Mrart
reviewed
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current local mode lacks loading additionalJars and flinkConf
Local mode is convenient for development and debug