[FLINK-38079] Add Pipeline support for DateType and TimeType #4060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxiqian
requested changes
Jul 15, 2025
There was a problem hiding this comment.
Thanks for @proletarians' nice work, just left some trivial comments.
| @@ -85,6 +93,37 @@ | |||
| */ | |||
| @PublicEvolving | |||
| public class SchemaMergingUtils { | |||
|
|
|||
There was a problem hiding this comment.
We may handle these changes in another PR and focus on supporting DATE and TIME formats here
| void testCalculatedColumns(ValuesDataSink.SinkApi sinkApi) throws Exception { | ||
| @ParameterizedTest(name = "API version: {0}, initializeMode: {1}") | ||
| @MethodSource(value = "parameterProvider") | ||
| void testCalculatedColumns(ValuesDataSink.SinkApi sinkApi, boolean initializeMode) |
There was a problem hiding this comment.
What is initializeMode? Seems it doesn't affect test cases at all.
| @@ -141,6 +143,7 @@ public void testMySql8JsonDataTypesWithUseLegacyJsonFormat() throws Throwable { | |||
|
|
|||
| @Test | |||
| void testMysql57TimeDataTypes() throws Throwable { | |||
| UniqueDatabase usedDd = fullTypesMySql57Database; | |||
There was a problem hiding this comment.
Please double check if these changes are necessary, and revert these to keep this PR minimum.
| @@ -48,6 +48,7 @@ public class DebeziumSchemaDataTypeInference implements SchemaDataTypeInference, | |||
|
|
|||
| private static final long serialVersionUID = 1L; | |||
|
|
|||
| public static final String DEBEZIUM_DATE_SCHEMA_NAME = "io.debezium.time.Date"; | |||
There was a problem hiding this comment.
Seems redundant as it's an alias of io.debezium.time.Date.SCHEMA_NAME?
Comment on lines
111
to
118
| if (o instanceof DateData) { | ||
| writer.writeDate(pos, (DateData) o); | ||
| } else { | ||
| writer.writeInt(pos, (int) o); | ||
| } | ||
| break; |
There was a problem hiding this comment.
We may add some comments here, clarifying that the writeInt paths are kept for compatibility.
proletarians
force-pushed
the
datetypesupport
branch
from
5a2b834 to
aa96a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline currently treats DateType and TimeType as plain INT, so date/time columns lose precision (TIME only to milliseconds, DATE range limited) and cannot be used with built-in temporal functions.