Skip to content

Conversation

bchapuis
Copy link
Member

@bchapuis bchapuis commented Jul 1, 2024

This pull request introduces:

  • A hillshade algorithm (raster to raster)
  • A contour algorithm (raster to vector)
  • A port of the martini algorithm (raster to 3d mesh)

@bchapuis bchapuis force-pushed the raster-processing branch from 38b70fe to 4eb2d23 Compare July 2, 2024 07:55
@bchapuis bchapuis force-pushed the raster-processing branch from 74fb471 to 7f7199d Compare July 23, 2024 13:55
@bchapuis bchapuis force-pushed the raster-processing branch 2 times, most recently from 7b130a1 to e61b8a5 Compare July 23, 2024 15:10
@bchapuis bchapuis force-pushed the raster-processing branch from e61b8a5 to 4c0c5bb Compare July 23, 2024 21:07
@bchapuis bchapuis force-pushed the raster-processing branch from af74140 to 9ba78e7 Compare July 31, 2024 14:18
return this;
}

public TranslateOptions srcWindow(int xoff, int yoff, int xsize, int ysize) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'ysize' is never used.
return this;
}

public WarpOptions tgtCoordEpoch(String epoch) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'epoch' is never used.
double trv = grid[y * width + (x + 1)];
double brv = grid[(y + 1) * width + (x + 1)];
double blv = grid[(y + 1) * width + x];
double avg = (tlv + trv + brv + blv) / 4.0;

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'double avg' is never read.

// Add listeners
ChangeListener listener = new ChangeListener() {
public void stateChanged(ChangeEvent e) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note test

This method overrides
ChangeListener.stateChanged
; it is advisable to add an Override annotation.

class BicubicInterpolation extends Interpolation {

public Dimension getSupportSize() {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
Interpolation.getSupportSize
; it is advisable to add an Override annotation.
// Resample and render the image
var gridCoverageProcessor = new GridCoverageProcessor();
gridCoverageProcessor.setInterpolation(new BicubicInterpolation());
var gridCoverage = gridCoverageProcessor.resample(this.gridCoverage, targetGridGeometry);

Check notice

Code scanning / CodeQL

Possible confusion of local and field Note

Potentially confusing name: method
read
also refers to field
gridCoverage
(as this.gridCoverage).
Copy link

import static org.junit.jupiter.api.Assertions.*;


class VectorHillshadeTileStoreTest {

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note test

Unused class: VectorHillshadeTileStoreTest is not referenced within this codebase. If not used as an external API it should be removed.
@bchapuis bchapuis closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant