Skip to content

Conversation

kgeis
Copy link

@kgeis kgeis commented Sep 3, 2024

Running the curl command as documented returns ["world"] and it should return ["hello", "world"].

Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomarko mind taking a look?

@domhanak domhanak changed the title KOGITO-fix hello world documentation POST example NO_ISSUE: Fix hello world documentation POST in dm-drools-springboot-metrics Jan 15, 2025
@domhanak domhanak changed the title NO_ISSUE: Fix hello world documentation POST in dm-drools-springboot-metrics NO_ISSUE: Fix hello world documentation POST in dmn-drools-springboot-metrics Jan 15, 2025
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this change. However there is discussion about the examples, also about the stable branch and I am not sure about its future.

https://lists.apache.org/thread/qc9vhod96mdoppo5ssj4f0pkqhzt4ghd

Could we please address this issue also on main branch?
https://github.com/apache/incubator-kie-kogito-examples/tree/main/kogito-springboot-examples/dmn-drools-springboot-metrics

@domhanak
Copy link
Contributor

@jomarko well the discussion does not lead anywhere, for the time being the examples development is here on main branch. The stable can be ignored for now. Imho we merge this so when the discussion finally comes to some conclussion we have examples in good shape.

@jomarko
Copy link
Contributor

jomarko commented Feb 3, 2025

@domhanak not sure if I understand. is your point to merge #2007 into stable or not to merge #2007 into stable

@domhanak
Copy link
Contributor

domhanak commented Feb 3, 2025

@jomarko oh apologies I totally did not notice it is against stable we should do it to main and 10.0.x, so I guess we either ask for backport PR's from @kgeis or we do it ourselves

@domhanak
Copy link
Contributor

domhanak commented May 1, 2025

Please open against main branch, stable is deprecated

@domhanak domhanak closed this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants