Skip to content

[#11048] Fix race condition in MessageUtils #11049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oehme
Copy link
Contributor

@oehme oehme commented Aug 15, 2025

Wait for the AnsiConsole#systemInstall call in the FastTerminal background thread before uninstalling. Otherwise a quickly finishing build might leave the terminal and system streams in a broken state.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@oehme oehme changed the title [#11048] Fix race condition in MessageUtils Fix #11048: Race condition in MessageUtils Aug 15, 2025
@oehme oehme changed the title Fix #11048: Race condition in MessageUtils [#11048] Fix race condition in MessageUtils Aug 15, 2025
Wait for the AnsiConsole#systemInstall call in the FastTerminal background thread before
uninstalling. Otherwise a quickly finishing build might leave the terminal and system streams
in a broken state.
@oehme oehme force-pushed the oehme/ansiconsole-race branch from 6fd1a05 to 6be3525 Compare August 15, 2025 20:20
@cstamas cstamas added the bug Something isn't working label Aug 16, 2025
@cstamas
Copy link
Member

cstamas commented Aug 16, 2025

This will need backport to 4.0.x as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants