Skip to content

Conversation

anuunchin
Copy link
Contributor

@anuunchin anuunchin commented May 26, 2025

Description

This PR resolves issue 3303 and is a part of the AMLS course.

Overview (as of now)

To resolve the issue, the following tasks are to be carried out:

  • Fix the warnings and errors currently thrown by the src/main/python/generator/generator.py.
  • Starting with the following builtin functions, add a python and dml example in a format of a code block, but under a different tag:
    • dist.dml
    • lm.dml
    • normalize.dml
    • toOneHot.dml
    • randomForest.dml
    • img_*.dml
  • Adjust src/main/python/generator/generator.py and src/main/python/generator/dml_parser.py accordingly to handle the python examples and transform them into test cases, possibly using a new script under src/main/python/generator/test_generator.py.

@anuunchin anuunchin force-pushed the docs/3330-docs-builtins branch from 512b5c0 to cc9f8d9 Compare May 29, 2025 19:11
@anuunchin anuunchin marked this pull request as ready for review May 29, 2025 19:38
Copy link
Contributor

@Baunsgaard Baunsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few early comments.

@anuunchin anuunchin force-pushed the docs/3330-docs-builtins branch 6 times, most recently from dba487b to 2364edf Compare June 11, 2025 10:04
@anuunchin anuunchin force-pushed the docs/3330-docs-builtins branch from 2364edf to 5cdc836 Compare June 11, 2025 10:11
@anuunchin
Copy link
Contributor Author

anuunchin commented Jul 13, 2025

This PR is separated into a prep PR #2291 that resolves existing issues thrown by generator.py and the main PR #2292.

@anuunchin anuunchin closed this Jul 13, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SystemDS PR Queue Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants