-
Notifications
You must be signed in to change notification settings - Fork 500
[SYSTEMDS-3877] Docker image size reduction and safety improvement #2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR, @alexanderschmi While looking into the docker images could we also look at security vulnerabilities: https://hub.docker.com/repository/docker/apache/systemds/general |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2274 +/- ##
============================================
- Coverage 72.96% 72.95% -0.01%
- Complexity 46090 46095 +5
============================================
Files 1479 1479
Lines 172655 172654 -1
Branches 33797 33796 -1
============================================
- Hits 125972 125965 -7
- Misses 37188 37209 +21
+ Partials 9495 9480 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for the PR, it is a great improvement! Based on your pictures, did we move the SystemDS folder to the root? If so, would it not be better if we move it back to the previous position? Also, which image is it referring too? Best regards |
Dockerfile Refactoring:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a quick pass, it looks great.
Please fix the remaining comments.
LGTM, will merge once the images are built. |
Purpose
Update Docker Images to run on Alpine Linux
What Changed