-
Notifications
You must be signed in to change notification settings - Fork 500
[SYSTEMDS-3862] SSB Benchmark Implementation #2280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ghafek
wants to merge
36
commits into
apache:main
Choose a base branch
from
ghafek:feature/ssb-benchmark
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcc4671
to
e7ae6b3
Compare
This patch refines the current union operation to an internal LOP operation. Currently, two subsequent operations -- rbind() and unique() are used to perform the union operation. We rewrite the operation with an internal LOP that uses a HashSet to compute the unique entries and returns them in a matrix. This improves the efficiency of the operation, as it avoids unique(). The order of the input entries is preserved in the output. Closes apache#2286.
This patch introduces a basic integration of the out-of-core backend. For reading, we use a dedicated reblock instruction which creates a queue of blocks, spawns a thread for reading and immediately returns. In addition, we extended the acquireRead functionality to collect such streams of blocks whenever an operations requires the full matrix. Based on these foundations, we can now add other OCC operations that directly work with the input stream of blocks and produce either results or created modified output streams.
The test failure of not finding the mtd-file did not show up in local tests, because locally we do not clean the test directories, and from development there were both Xmtd and X.mtd existing.
This patch introduces the out-of-core unary aggregate operations as an example of how to implement operations against the input stream of blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.