-
-
Notifications
You must be signed in to change notification settings - Fork 42
A new JsonConverterOptions attribute for new converter management #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Erifirin
wants to merge
4
commits into
applejag:master
Choose a base branch
from
Erifirin:feature/converter-options-attribute
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7546d5d
added JsonConverterOptions attribute for future customizations and pr…
Erifirin bae9f9c
JsonConverterOptions replaced with HideInJsonConverterSettings
Erifirin 5aca2ee
added test case to check availability of "visible" json converter
Erifirin 3b01bf2
added summary to HideInJsonConverterSettings (draft)
Erifirin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
60 changes: 60 additions & 0 deletions
60
Assets/Newtonsoft.Json.UnityConverters.Tests/Features/HiddenConverterTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
using System; | ||
using System.Linq; | ||
using NUnit.Framework; | ||
|
||
namespace Newtonsoft.Json.UnityConverters.Tests | ||
{ | ||
public class HiddenConverterTests | ||
{ | ||
[Test] | ||
public void AssertHiddenConverterNotRegistered() | ||
{ | ||
var registered = UnityConverterInitializer.defaultUnityConvertersSettings.Converters | ||
.Any(x => x.GetType() == typeof(TestHiddenJsonConverter)); | ||
|
||
Assert.IsFalse(registered, "TestHiddenJsonConverter registered, but should not."); | ||
} | ||
|
||
[Test] | ||
public void AssertVisibleConverterRegistered() | ||
{ | ||
var registered = UnityConverterInitializer.defaultUnityConvertersSettings.Converters | ||
.Any(x => x.GetType() == typeof(TestVisibleJsonConverter)); | ||
|
||
Assert.IsTrue(registered, "TestVisibleJsonConverter not registered, but should be."); | ||
} | ||
|
||
|
||
[HideInJsonConverterSettings] | ||
internal class TestHiddenJsonConverter : JsonConverter | ||
{ | ||
public override bool CanConvert(Type objectType) => false; | ||
|
||
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer) | ||
{ | ||
throw new NotImplementedException(); | ||
} | ||
|
||
public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) | ||
{ | ||
throw new NotImplementedException(); | ||
} | ||
} | ||
|
||
|
||
internal class TestVisibleJsonConverter : JsonConverter | ||
{ | ||
public override bool CanConvert(Type objectType) => false; | ||
|
||
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer) | ||
{ | ||
throw new NotImplementedException(); | ||
} | ||
|
||
public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) | ||
{ | ||
throw new NotImplementedException(); | ||
} | ||
} | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
Assets/Newtonsoft.Json.UnityConverters.Tests/Features/HiddenConverterTests.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
11 changes: 11 additions & 0 deletions
11
Packages/Newtonsoft.Json-for-Unity.Converters/UnityConverters/HideInJsonConverterSettings.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
using System; | ||
|
||
namespace Newtonsoft.Json.UnityConverters | ||
{ | ||
/// <summary> | ||
/// The attribute allows to hide JsonConverter from Json.Net converters settings | ||
/// and exclude it from auto sync process. | ||
/// </summary> | ||
[AttributeUsage(AttributeTargets.Class, AllowMultiple = false)] | ||
public class HideInJsonConverterSettings : Attribute { } | ||
} |
11 changes: 11 additions & 0 deletions
11
.../Newtonsoft.Json-for-Unity.Converters/UnityConverters/HideInJsonConverterSettings.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a doc comment on this type to explain how it works and why you would use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try. But I'm not good at English))) Maybe you'll want to do it yourself later.