Fix potential panic in ConstraintTrace display formatting #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
fmt::Display
implementation forConstraintTrace
usedmetadata.module_path().unwrap()
, which could panic if the module path is not available for certain spans (e.g., from macros or external sources).Solution
Replace
unwrap()
withunwrap_or(metadata.target())
to provide a safe fallback using the span's target as an alternative identifier.Changes
relations/src/gr1cs/trace.rs
metadata.module_path().unwrap()
metadata.module_path().unwrap_or(metadata.target())