Skip to content

always pair astropy and asdf unit/quantity tags #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

braingram
Copy link
Contributor

@braingram braingram commented May 21, 2025

This PR adds a test to verify that any unit tag is part of an anyOf including both the asdf and astropy tags (which is used depends on the unit selected) and updates schemas (all unreleased) to include both tags where needed.

@braingram braingram marked this pull request as ready for review May 22, 2025 12:24
@braingram braingram requested a review from nden May 22, 2025 12:24
@braingram braingram marked this pull request as draft May 27, 2025 14:19
@braingram braingram marked this pull request as ready for review May 27, 2025 14:24
Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram merged commit 9b4c6f0 into asdf-format:main May 27, 2025
12 of 13 checks passed
@braingram braingram deleted the unit_test branch May 27, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants