nested record duplicates #359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that: includes include_a: [include_a: [:include_a]] is the same as includes include_a: [include_a: []] It was already the case but this makes it explicit.
|
Yeah, I think the fix won't be able to be using Could you pare this down just to a failing test? We can then explore solutions. |
|
Should we write more tests ? |
|
It looks like the feature you're working on got added in? Main thing we want to start w/ is a test that fails proving the issue, and then we can explore what the cause is and how to avoid the issue w/o using |
|
Ooops. I probably rebased the branch, then forgot, then pushed the revert... |
|
I messed it up, sorry. I close this PR and open a clean one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a commit about the missing linkage data. Turns out it's not related to my json_api_resources-like always_include_linkage implementation. It also happens when including deep nested relations.
I'm not sure about the fix though. It seems straightforward, but I wonder if it could lead to other side-effect problems, like different include paths producing multiple versions of the same record, with different preloaded data.
Also, I'm not sure if Enum.uniq is the way to go, or if it would be better to dedup on type + id only.
Contributor checklist
Leave anything that you believe does not apply unchecked.