support index queries with generic actions #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabasJ
force-pushed
the
feature/support-using-generic-actions-with-index
branch
from
95eddc4 to
75a7a8b
Compare
barnabasJ
force-pushed
the
feature/support-using-generic-actions-with-index
branch
from
75a7a8b to
1d1d6a3
Compare
barnabasJ
force-pushed
the
feature/support-using-generic-actions-with-index
branch
from
5d1e1d4 to
b2b7000
Compare
barnabasJ
commented
Jul 17, 2025
Comment on lines
62
to
64
| request | ||
| |> fields(request.resource) | ||
| |> Enum.filter(&(&1 not in Ash.Resource.Info.attribute_names(request.resource))), |
There was a problem hiding this comment.
So this was actually why it tried to load when I ran into the problem with the index query. Can we do this, or are there potential side-effects.
If so, there are more places with the same logic that I need to update.
There was a problem hiding this comment.
🤔 No, this load is also effetcively doing an "ensure selected" on the fields in question. You can do this conditionally if there is no primary read action perhaps?
There was a problem hiding this comment.
That would probably only be relevant for generic actions here? No need to change it for other actions?
zachdaniel
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.