fix: recursive input types #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes stack overflow issues when generating OpenAPI schemas for embedded resources with self-references in create/update operations. Changes: - Add seen_input_types tracking to accumulator for recursion detection - Pass parent resource context to embedded_type_input for proper naming - Generate context-aware schema names (parent_type_attribute-input-action) - Create $ref references for recursive types instead of inline definitions - Ensure all referenced schemas are properly created and stored - Fix accumulator flow to preserve schemas from request_body generation This prevents infinite recursion and ensures OpenAPI client generation tools can resolve all $ref references correctly.
- Add comprehensive test for recursive embedded input types without stack overflow - Update existing test to expect $ref instead of inline schema for embedded inputs - Verify that all referenced schemas are properly created in components - Ensure OpenAPI client generation won't fail with missing $ref errors
Apply mix format to maintain consistent code style
Follow the same pattern as regular embedded types:
- Remove unnecessary minimal schema creation for recursive types
- Just return $ref for recursive types with schema names
- Return empty Schema{} for recursive types without names
- Let the non-recursive path create the actual schema
This simplifies the code and removes unnecessary complexity that
wasn't actually helping with recursion prevention.
Move the require Logger statement to module level for cleaner code organization and remove accidental error logging that referenced undefined variable.
Move all schema generation and verification into the capture_log block to ensure any warnings during the process are captured for verification. This provides better test coverage for the recursion detection logging.
zachdaniel
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.