Skip to content

Fix bugs in examples #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Fix bugs in examples #357

merged 3 commits into from
Oct 9, 2024

Conversation

tkoskela
Copy link
Contributor

@tkoskela tkoskela commented Oct 8, 2024

I tried building the examples and found and fixed a few bugs

@tkoskela tkoskela requested review from mmcleod89 and 20DM October 8, 2024 11:25
for (t_real k = 0; k < uv_data.size(); k++) {
for (t_int k = 0; k < uv_data.size(); k++) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honorary mention to this 🐛

Copy link
Collaborator

@20DM 20DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Copy link
Collaborator

@20DM 20DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tkoskela tkoskela merged commit 4ad17e3 into development Oct 9, 2024
14 checks passed
@tkoskela tkoskela deleted the tk/debug_examples branch October 9, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants