Skip to content

csv2hdf5: improve usability of conversion script #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

20DM
Copy link
Collaborator

@20DM 20DM commented Feb 13, 2025

This is to make the script more command-line-friendly.

@20DM 20DM requested a review from tkoskela February 13, 2025 14:37
Copy link
Contributor

@tkoskela tkoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have all the dependencies in my python env. Should this come with a requirements.txt/pyproject.toml or something like that?

@20DM
Copy link
Collaborator Author

20DM commented Feb 13, 2025

This is an optional utility script, not a fully fledged Python package, so no to requirements.txt/pyproject.toml, but I've clarified the error message when hdf5py cannot be found. If the user wants to write out an HDF5 file with a Python script, having hdf5py installed would help of course.

Copy link
Contributor

@tkoskela tkoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@20DM 20DM merged commit ade40ff into development Feb 13, 2025
14 checks passed
@20DM 20DM deleted the cg_conv_script_improvements branch February 13, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants