Skip to content

Use static variables to avoid recalculating the norm #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2025

Conversation

mmcleod89
Copy link
Contributor

This will allow us to benchmark the stochastic algorithm with the norm only calculated once, and compare for both performance and accuracy with the more legitimate calculation of a new norm every iteration.

@mmcleod89 mmcleod89 requested a review from tkoskela April 2, 2025 13:15
Copy link
Contributor

@tkoskela tkoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as #389 is merged

@tkoskela tkoskela merged commit 7779be2 into development Apr 3, 2025
16 checks passed
@tkoskela tkoskela deleted the mm/ApproxNormedStochasticBenchmark branch April 3, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants