Skip to content

DOC: mast Documentation Updates #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

snbianco
Copy link
Contributor

Updating our documentation to give a clear example of a criteria query using positional keyword arguments.

Also updated the Zcut documentation to pass tests. Zcut was recently updated to use a newer version of Astrocut, so the naming convention for downloaded files has changed slightly.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.09%. Comparing base (a4357f6) to head (fe46b3c).
Report is 183 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3274   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files         232      232           
  Lines       19677    19677           
=======================================
  Hits        13595    13595           
  Misses       6082     6082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snbianco
Copy link
Contributor Author

ReadTheDocs build is failing, but I don't think it's related to MAST.

@snbianco snbianco requested a review from bsipocz March 25, 2025 17:11
@snbianco snbianco marked this pull request as ready for review March 25, 2025 17:11
@bsipocz bsipocz changed the title Documentation Updates DOC: mast Documentation Updates Mar 25, 2025
@bsipocz bsipocz added this to the v0.4.11 milestone Mar 25, 2025
@bsipocz
Copy link
Member

bsipocz commented Mar 25, 2025

I also see errors in docs/mast/mast_missions.rst, would you mind to have a look at it, too?

@snbianco
Copy link
Contributor Author

I also see errors in docs/mast/mast_missions.rst, would you mind to have a look at it, too?

It was actually a problematic node on one of our APIs that was causing those errors. The tests should pass now!

@bsipocz
Copy link
Member

bsipocz commented Mar 25, 2025

yeap, it passed now. Thanks!

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's all passing now.

@bsipocz bsipocz merged commit ebcbe4c into astropy:main Mar 25, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants