Skip to content

BUG: fix Heasarch.locate_data returning empty rows #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

zoghbi-a
Copy link
Contributor

@zoghbi-a zoghbi-a commented Mar 26, 2025

Heasarc.locate_data returns empty rows with an error in the error_message column if there are no data associated with that row rather than filtering it out. fixes #3271.

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.37%. Comparing base (9dca39b) to head (af2d6f4).
Report is 175 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/heasarc/core.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3275   +/-   ##
=======================================
  Coverage   69.37%   69.37%           
=======================================
  Files         232      232           
  Lines       19684    19686    +2     
=======================================
+ Hits        13655    13657    +2     
  Misses       6029     6029           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz changed the title Fix 3271 BUG: fix Heasarch.locate_data returning empty rows Mar 26, 2025
@bsipocz bsipocz added this to the v0.4.11 milestone Mar 26, 2025
@bsipocz
Copy link
Member

bsipocz commented Mar 26, 2025

Could you please add some descriptive titles next time? It will make maintainers' life easier. Also, if possible please add labels and such. Thanks!

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix.

@bsipocz bsipocz merged commit d4266ea into astropy:main Mar 26, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

astroquery.heasarc.locate_data doesn't returns links for some rows
2 participants