-
-
Notifications
You must be signed in to change notification settings - Fork 420
Changed visual to have mpl kwargs for Alma #3285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3285 +/- ##
==========================================
- Coverage 69.38% 69.37% -0.01%
==========================================
Files 232 232
Lines 19682 19689 +7
==========================================
+ Hits 13656 13659 +3
- Misses 6026 6030 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, however, could you please add a test to astroquery/alma/tests/test_alma_utils.py (practically your example in #3283 should suffice); and also a changelog entry to CHANGES.rst?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a minor fix for a namespace. I commit that directly so this can go in once CI is clean.
Thank you @SpacialTree for the fix, and congrats on your first contribution to astroquery. I hope to see more of these in the future! |
Following the discussion of the bug preventing regions queried from ALMA in Issue #3283, this pull request fixes the bug by changing
visual
to have keywords that work with matplotlib.