Skip to content

Changed visual to have mpl kwargs for Alma #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

SpacialTree
Copy link
Contributor

Following the discussion of the bug preventing regions queried from ALMA in Issue #3283, this pull request fixes the bug by changing visual to have keywords that work with matplotlib.

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.37%. Comparing base (f021816) to head (4c2caa2).
Report is 169 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3285      +/-   ##
==========================================
- Coverage   69.38%   69.37%   -0.01%     
==========================================
  Files         232      232              
  Lines       19682    19689       +7     
==========================================
+ Hits        13656    13659       +3     
- Misses       6026     6030       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz added this to the v0.4.11 milestone Apr 8, 2025
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, however, could you please add a test to astroquery/alma/tests/test_alma_utils.py (practically your example in #3283 should suffice); and also a changelog entry to CHANGES.rst?

Thanks!

@bsipocz bsipocz linked an issue Apr 8, 2025 that may be closed by this pull request
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a minor fix for a namespace. I commit that directly so this can go in once CI is clean.

@bsipocz bsipocz merged commit 3172b82 into astropy:main Apr 8, 2025
10 checks passed
@bsipocz
Copy link
Member

bsipocz commented Apr 8, 2025

Thank you @SpacialTree for the fix, and congrats on your first contribution to astroquery. I hope to see more of these in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALMA footprint regions have dash keyword
2 participants