Skip to content

ENH: do not include image metadata tables in catalog list #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 13, 2025

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 3, 2025

This PR makes the query behind list_catalogs more explicit to not return the image metadata tables by default. These tables are not suitable to be used for the spatial queries we have in query_region, etc.

This fully fixes #3330 and closes #3332

cc @vandesai1

@bsipocz bsipocz added this to the v0.4.11 milestone Jun 3, 2025
@bsipocz bsipocz requested a review from keflavich June 3, 2025 20:01
@bsipocz bsipocz added the bug label Jun 3, 2025
@bsipocz bsipocz force-pushed the ENH_irsa_no_metadata_tables branch from 099d549 to e3eca6e Compare June 4, 2025 19:22
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.86%. Comparing base (d7cdfd7) to head (e3eca6e).
Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/ipac/irsa/core.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3334      +/-   ##
==========================================
- Coverage   69.87%   69.86%   -0.02%     
==========================================
  Files         232      232              
  Lines       19770    19773       +3     
==========================================
  Hits        13815    13815              
- Misses       5955     5958       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz merged commit 5606fd9 into astropy:main Jun 13, 2025
11 of 13 checks passed
@bsipocz bsipocz deleted the ENH_irsa_no_metadata_tables branch June 13, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: IRSA should not include image metadata table in list_collection by default BUG: IRSA: Some catalogs produce bad queries
2 participants