-
-
Notifications
You must be signed in to change notification settings - Fork 420
BUGFIX: http->https in skyview #3346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3346 +/- ##
=======================================
Coverage 70.08% 70.08%
=======================================
Files 232 232
Lines 19890 19890
=======================================
Hits 13940 13940
Misses 5950 5950 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hahh, I guess I better push small fixes more frequently, I have that doctest fixed on a local branch since April 😅 |
(haven't notice it in time, but please use the magic words right before the PR number next time |
Ahhh crap, I can't say "resolves issue X", I have to say "resolves X"!?!? argh, I'm a terrible magician |
Hi there. Thanks a lot for tip Adam. |
@carlos-lco thanks for the note; that seems like an issue that needs to be posted on astroplan - is there one open? |
Yes, SkyView # 588. I just noticed it. And you wrote on it! I should investigate more before posting. Sorry. |
No worries. That was a long time ago (in my head anyway), I forgot about it. Would you be interested in trying to fix that issue? I'm sure a pull request would be welcome. |
This latest change in skyview is really just about the server side turning off the http access due to their DoS attacks. , the underlying API has not changed. (That being said, it would be great if downstream would fix these sooner rather than later). |
I just did. Crossed fingers. :) |
Resolves Issue #3345, i.e., the upstream bug in which queries hang indefinitely.
If you've arrived here from another issue, please install the latest astroquery version. The skyview problems reported in June 2025 have been solved.