Skip to content

use new pytest asdf plugin #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Aug 19, 2025

Update test dependencies to use new https://pypi.org/project/pytest-asdf-plugin/ which is a feature-compatible replacement for the bundled asdf pytest plugin (which will soon be deprecated).

For context the pytest-asdf-plugin is responsible for finding and converting schema files into "tests" (to check the schema against the metaschema and validated any contained "examples"). Since both the bundled and now external plugins are feature-compatible there should be no change in test number (or new failures, etc).

On main 572 tests passed:
https://github.com/astropy/specutils/actions/runs/16924368657/job/47957149583#step:5:183

With this PR 572 tests passed:
https://github.com/astropy/specutils/actions/runs/17070847734/job/48399089755?pr=1265#step:5:184

Let me know if this needs a changelog if if there is a label to add to skip this check (I don't have permissions to change the labels).

@braingram braingram marked this pull request as ready for review August 19, 2025 13:22
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.84%. Comparing base (ef3d727) to head (c7a1131).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1265   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files          63       63           
  Lines        4743     4743           
=======================================
  Hits         4119     4119           
  Misses        624      624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rosteen rosteen added no-changelog-entry-needed changelog bot directive testing labels Aug 19, 2025
Copy link
Contributor

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this wasn't on my radar at all.

@rosteen rosteen merged commit aa8e9be into astropy:main Aug 20, 2025
22 of 26 checks passed
@braingram braingram deleted the pytest-asdf-plugin branch August 20, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants