Skip to content

MAINT: fix assignment for sphinxdev (8.3) compatibility #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 18, 2025

This fixes some of the fixes for #214, thanks Adam!

I would say merge this if indeed there are fewer failues rather than waiting for the fix for problem 1

@bsipocz bsipocz requested a review from pllim August 18, 2025 22:36
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (208efd0) to head (dd9b3a0).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          31       31           
  Lines        1252     1252           
=======================================
  Hits         1123     1123           
  Misses        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 18, 2025

Changlelog failure is OK and preferred, this, along with any possibly others will get a "fix compatibility with sphinx ..." right before releasing.

@pllim pllim added this to the v0.21.0 milestone Aug 19, 2025
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yes, we can deal with the rest separately.

@pllim pllim merged commit 63aea56 into astropy:main Aug 19, 2025
17 of 21 checks passed
@pllim
Copy link
Member

pllim commented Aug 19, 2025

p.s. That was a milestone check, not a change log check.

@bsipocz bsipocz deleted the MAINT_fix_sphinxdev_assignment branch August 19, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants