Fix editLink for products not accounting for orgName from repositories.json #74

Copilot · 2025-06-11T11:54:44Z

The editLink generation for product pages was not correctly using the organization name from repositories.json, causing external repositories (like nixel2007/extends) to generate incorrect GitHub edit links pointing to autumn-library instead of their actual organization.

Issue

For the repository nixel2007/extends, the generated edit link was:

https://github.com/autumn-library/extends/edit/master/docs/product/...

Instead of the correct:

https://github.com/nixel2007/extends/edit/master/docs/product/...

Root Cause

Two issues were causing this problem:

transformPageData was not cleaning repository names - it used the raw name with sorting prefix (e.g., 003-extends) to look up organization data, but repositories.json maps clean names (e.g., extends)
editLink pattern was using pageData.filePath (rewritten path after URL rewrites) instead of pageData.relativePath (original path before rewrites) to extract repository names

Solution

Fixed transformPageData to clean repository names by removing the sorting prefix (\d+-) before looking up organization data
Updated editLink pattern to use pageData.relativePath for repository name extraction, ensuring consistency with transformPageData

Testing

Verified that:

nixel2007/extends now generates correct edit links with nixel2007 organization
Build process continues to work without errors
Other repositories remain unaffected

Fixes #73.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

…epositories.json Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

coderabbitai · 2025-06-11T12:04:56Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

nixel2007 · 2025-06-11T12:06:34Z

.vitepress/config.mts

@@ -20,7 +20,8 @@ export default defineConfig({
    const repositoriesMap: Map<string, RepoData> = new Map(repositories.map((repoData: RepoData) => [repoData.repository, repoData]));

    const repoName = pageData.relativePath.split('/')[1];
-    const repoData = repositoriesMap.get(repoName);
+    const cleanRepoName = repoName?.replace(/\d+-/g, '');


inline this

Inlined the variable as requested in commit a6453c2

nixel2007 · 2025-06-11T12:21:23Z

.vitepress/config.mts

        const organization = pageData.params?.organization;

-        const [_, repoName, ...rest] = filePath.split('/')
+        // Use relativePath to get the original repository name (before rewrites)
+        const [_, repoName, ...rest] = relativePath.split('/')


что-то не сходится. раз это до рерайтов, значит, здесь имя репозитория будет с цифрами в начале. в filePath цифр уже быть не должно, а значит и replace строкой ниже уже не нужен.

You're right about the logic. I'm using relativePath (before rewrites) so the repo name has prefixes like 003-extends, which is why I need the replace(/\d+-/g, '') on line 164. This is consistent with transformPageData which also uses relativePath and cleans the name for organization lookup. Would you prefer I use filePath instead and remove the replace, or keep the current consistent approach?

Используй filePath

Changed to use filePath instead of relativePath and removed the manual cleaning since filePath is already processed by URL rewrites. Commit 816719e

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

nixel2007 · 2025-06-11T12:34:01Z

.vitepress/config.mts

-          return `https://github.com/${orgName}/${repoNamePath}/edit/master/docs/product/${restPath}`
-        }
-        return ''      
+        // For products (after rewrites, products/ prefix is removed)


нене, вот здесь (и на 160 строке) как раз можно проверить relativePath. там же должно быть и /api и /product по идее.
ну и вырни обратно обший расчет repoName, orgName и restPathю они же одинаковые в таком случае

Changed to use relativePath for path checks and restored common calculation of repoName, orgName and restPath as requested. Commit 718e717

Vitepress хостит не только /api и /product. Верни проверку на product обратно

Added back specific check for relativePath.startsWith('products/') instead of using catch-all. Now properly handles cases where VitePress hosts paths other than /api and /product by returning empty string for unmatched paths. Commit f9a40a6

…s requested Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

nixel2007 · 2025-06-11T13:24:41Z

.vitepress/config.mts

@@ -20,7 +20,7 @@ export default defineConfig({
    const repositoriesMap: Map<string, RepoData> = new Map(repositories.map((repoData: RepoData) => [repoData.repository, repoData]));

    const repoName = pageData.relativePath.split('/')[1];
-    const repoData = repositoriesMap.get(repoName);
+    const repoData = repositoriesMap.get(repoName?.replace(/\d+-/g, ''));


Move replace to the line with repoName calculation

Moved replace operation inline with repoName calculation in both transformPageData and editLink pattern. Now uses repoName?.replace(/\d+-/g, '') directly in the assignment. Commit f9a40a6

nixel2007 · 2025-06-11T15:01:19Z

.vitepress/config.mts

-          return `https://github.com/${orgName}/${repoNamePath}/edit/master/docs/product/${restPath}`
-        }
-        return ''      
+        // For products (after rewrites, products/ prefix is removed)


Vitepress хостит не только /api и /product. Верни проверку на product обратно

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

nixel2007 · 2025-06-11T15:16:51Z

@copilot после твоих правок edit link в разделе с описанием продуктов вообще не работает. Api работает.

Initial plan for issue

5efdd92

Copilot AI assigned Copilot and nixel2007 Jun 11, 2025

Copilot started work on behalf of nixel2007 June 11, 2025 11:54 View session

Copilot AI and others added 2 commits June 11, 2025 11:58

Initial assessment: Understand the editLink issue with orgName from r…

2e05593

…epositories.json Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Fix editLink to use correct orgName from repositories.json

a6453c2

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] editLink для продуктов не учитывает orgName из repositories.json~~ Fix editLink for products not accounting for orgName from repositories.json Jun 11, 2025

Copilot AI requested a review from nixel2007 June 11, 2025 12:03

Copilot finished work on behalf of nixel2007 June 11, 2025 12:03

nixel2007 marked this pull request as ready for review June 11, 2025 12:04

nixel2007 requested changes Jun 11, 2025

View reviewed changes

Copilot started work on behalf of nixel2007 June 11, 2025 12:21 View session

Inline cleanRepoName variable as requested in code review

63ccb0a

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Copilot finished work on behalf of nixel2007 June 11, 2025 12:26

Copilot started work on behalf of nixel2007 June 11, 2025 12:28 View session

Use filePath instead of relativePath for editLink pattern as requested

816719e

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Copilot finished work on behalf of nixel2007 June 11, 2025 12:32

nixel2007 reviewed Jun 11, 2025

View reviewed changes

Copilot started work on behalf of nixel2007 June 11, 2025 12:34 View session

Use relativePath for path checks and restore common repo extraction a…

718e717

…s requested Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Copilot finished work on behalf of nixel2007 June 11, 2025 12:37

nixel2007 requested changes Jun 11, 2025

View reviewed changes

Copilot started work on behalf of nixel2007 June 11, 2025 15:01 View session

Add back products/ check and inline replace operations as requested

f9a40a6

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Copilot finished work on behalf of nixel2007 June 11, 2025 15:07

nixel2007 merged commit 8858133 into master Jun 11, 2025
2 checks passed

Fix editLink for products not accounting for orgName from repositories.json #74

Fix editLink for products not accounting for orgName from repositories.json #74

Uh oh!

Conversation

Copilot AI commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Root Cause

Solution

Testing

Uh oh!

coderabbitai bot commented Jun 11, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

nixel2007 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

nixel2007 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

nixel2007 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

nixel2007 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

nixel2007 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

nixel2007 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

nixel2007 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nixel2007 commented Jun 11, 2025

Uh oh!

Uh oh!

Copilot AI commented Jun 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)