Skip to content

Only run OU and Account list validations if ALT was enabled #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

ksamyak-aws
Copy link
Contributor

@ksamyak-aws ksamyak-aws commented Feb 13, 2025

It is possible for subsequent operations to fail if the previous operation had an account list + OU list but no filter specified and the current operation has all three specified. This change updates our validation logic to only apply these validations during ALT since that is when both lists are applicable.

Changes:

Updated validations for OU and Account list to only happen for ALT operations.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ksamyak-aws ksamyak-aws marked this pull request as ready for review February 14, 2025 18:34
@oshardik oshardik requested review from oshardik and removed request for oshardik February 14, 2025 19:14
@ksamyak-aws ksamyak-aws merged commit 7080e66 into aws-cloudformation:master Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants