feat(Github Action): Add all version in test action #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we just do test for the current lua version used by our eluna and probably the previous or stable one? |
For the past few months, the choice of which Lua version to use in Eluna has been free—the developer chooses the version. By default, it’s Lua52. All Lua versions are stable except 5.5, which is still in beta. Testing with all versions ensures that any modification is properly supported by Lua. Moreover, if I hadn’t manually tested every version, I would never have noticed that mod-eluna didn’t work with Lua 5.1. The fix for Lua5.1 : #291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding all version for compilation test.
The action https://github.com/azerothcore/mod-eluna/actions/runs/17073972607/job/48410928829?pr=292 will be fixed with #291