Add customizable PARTITION BY support for ClickHouse tables #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add partition_bys config option similar to indexes with database/table filtering - Support custom PARTITION BY expressions to override default intDiv(id, 4294967) - Useful for time-based partitioning like toYYYYMM(created_at) for Snowflake IDs - Maintains backward compatibility with existing default behavior - Add test verification for custom partition_by functionality Fixes #161
- Add proper deterministic partition_by expression: intDiv(id, 1000000) - Update test to verify custom vs default partition expressions - Ensure both CONFIG_FILE and CONFIG_FILE_MARIADB tests pass - Fix CI failures caused by non-deterministic partition expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for customizable
PARTITION BYexpressions in ClickHouse table creation to address issues with Snowflake IDs creating too many partitions.Changes
partition_byswith database/table filtering (similar toindexes)intDiv(id, 4294967)with user-defined partition logicConfiguration Example
Problem Solved
Fixes issue where Snowflake-style IDs (e.g.,
1849360358546407424) with default partitioning create excessive partitions, triggeringmax_partitions_per_insert_blocklimits. Users can now specify time-based partitioning liketoYYYYMM(created_at).Fixes #161