Skip to content

Add user to existing subfolder if it exists #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

Add user to existing subfolder if it exists #310

merged 1 commit into from
Jun 27, 2025

Conversation

TimCsaky
Copy link
Contributor

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3773?

  • when adding a subfolder (using createChildBucket endpoint), if sub-folder already exists in COMS db, instead of returning 409 collision, give current user permissions to that sub-folder.
  • when creating subfolder only require CREATE permission on the parent.

this will for example in bcbox, allow an external partner only given permission to upload into a folder, ability to create new subfolder.. on which they will also only have CREATE permission.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Jun 25, 2025

Coverage Report

Totals Coverage
Statements: 55.95% ( 3051 / 5453 )
Methods: 46.05% ( 332 / 721 )
Lines: 62.55% ( 1829 / 2924 )
Branches: 49.23% ( 890 / 1808 )

@TimCsaky TimCsaky merged commit 78b71e4 into master Jun 27, 2025
13 checks passed
@norrisng-bc norrisng-bc deleted the child branch July 23, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant