Skip to content

ui: export descriptor #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024
Merged

ui: export descriptor #233

merged 2 commits into from
Oct 18, 2024

Conversation

reez
Copy link
Collaborator

@reez reez commented Oct 10, 2024

Description

Try's to solve #230

Still a WIP and not exactly what we want because we don't have these yet:

  • Only copies descriptor, but not change descriptor
  • does not have "share" button (other related request)
  • descriptor format is prv
  • descriptor format uses tick not "h" /86'/1'/0'/0/*

Simulator Screenshot - iPhone 16 Pro - 2024-10-10 at 15 18 15

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez changed the title ui: export descriptor (draft) ui: export descriptor Oct 10, 2024
@reez reez changed the title (draft) ui: export descriptor ui: export descriptor Oct 18, 2024
@reez reez merged commit 5d58dd6 into bitcoindevkit:main Oct 18, 2024
1 check passed
@reez reez deleted the descript branch October 18, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant