Skip to content

refactor: client #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 30, 2025
Merged

refactor: client #314

merged 9 commits into from
Jul 30, 2025

Conversation

reez
Copy link
Collaborator

@reez reez commented Jul 28, 2025

Description

Abstracting client into its own type (in hopes of adding additional client types as PR's on top of this)

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • UI changes tested on small, medium, and large devices to ensure layout consistency

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez requested a review from r1b2ns July 28, 2025 15:09
@reez
Copy link
Collaborator Author

reez commented Jul 28, 2025

Testing this seemed to work just fine so far

@reez
Copy link
Collaborator Author

reez commented Jul 28, 2025

Testing this seemed to work just fine so far

Ran into one weird bug (might have been intro'd in bip84 pr?) but tried to fix with ee90b03 , and all the little commits from there on are making sure cut down code with no regressions

Bug: Delete wallet -> kill app -> re-run app and switch bip address ... would do nothing on "create wallet"

Copy link
Collaborator

@r1b2ns r1b2ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Great improvement. I really liked it! 🔥

@reez
Copy link
Collaborator Author

reez commented Jul 28, 2025

ACK

Great improvement. I really liked it! 🔥

alright good to know it aligns close enough with the good work you did in #296 ! I'll keep testing this weird bug that may or may not be related to this PR, and then hopefully merge this week, and then can keep building on top of this by adding Kyoto etc

@reez reez merged commit 3317d2b into bitcoindevkit:main Jul 30, 2025
1 check passed
@reez reez deleted the cleye branch July 30, 2025 15:58
@reez reez mentioned this pull request Jul 31, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants