-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: client #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: client #314
Conversation
Testing this seemed to work just fine so far |
Ran into one weird bug (might have been intro'd in bip84 pr?) but tried to fix with ee90b03 , and all the little commits from there on are making sure cut down code with no regressions Bug: Delete wallet -> kill app -> re-run app and switch bip address ... would do nothing on "create wallet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Great improvement. I really liked it! 🔥
alright good to know it aligns close enough with the good work you did in #296 ! I'll keep testing this weird bug that may or may not be related to this PR, and then hopefully merge this week, and then can keep building on top of this by adding Kyoto etc |
Description
Abstracting client into its own type (in hopes of adding additional client types as PR's on top of this)
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
.swift-format
fileNew Features:
Bugfixes: