Skip to content

feat: add balance formatting across the app #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

r1b2ns
Copy link
Collaborator

@r1b2ns r1b2ns commented Aug 17, 2025

Description

This solves #307 by applying balance formatting across the app.

Screen

Home Screen

Simulator Screenshot - iPhone 15 Pro Max - 2025-08-17 at 10 26 50 Simulator Screenshot - iPhone 15 Pro Max - 2025-08-17 at 10 26 47 Simulator Screenshot - iPhone 15 Pro Max - 2025-08-17 at 10 26 45 Simulator Screenshot - iPhone 15 Pro Max - 2025-08-17 at 10 26 38 Simulator Screenshot - iPhone 15 Pro Max - 2025-08-17 at 10 26 42

Transactions Screen

Simulator Screenshot - iPhone 15 Pro Max - 2025-08-17 at 10 33 41

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • UI changes tested on small, medium, and large devices to ensure layout consistency

@r1b2ns r1b2ns self-assigned this Aug 17, 2025
@r1b2ns r1b2ns marked this pull request as ready for review August 17, 2025 13:37
@r1b2ns r1b2ns requested a review from reez August 17, 2025 13:38
@r1b2ns r1b2ns changed the title draft feat: add balance formatting across the app feat: add balance formatting across the app Aug 17, 2025
@reez
Copy link
Collaborator

reez commented Aug 18, 2025

screenshots of this look great, will review code today, pumped!

@reez
Copy link
Collaborator

reez commented Aug 18, 2025

Tested, what you have looks and works great and the code fits in nicely with the codebase.

I think my only ask would be to apply the balance format to 2 more screens:

  • TransactionDetailView.swift
  • LocalOutputItemView.swift

So no code changes needed on current code, but just if you can add the way you are applying balance formatting to 2 additional views.

@r1b2ns
Copy link
Collaborator Author

r1b2ns commented Aug 18, 2025

Tested, what you have looks and works great and the code fits in nicely with the codebase.

I think my only ask would be to apply the balance format to 2 more screens:

  • TransactionDetailView.swift
  • LocalOutputItemView.swift

So no code changes needed on current code, but just if you can add the way you are applying balance formatting to 2 additional views.

Awesome, I’ll do this this evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants