-
Notifications
You must be signed in to change notification settings - Fork 71
docs/bdk-cli/installation.md:allow for individual copy/paste #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
this change allows each command to be copied individually. https://deploy-preview-186--awesome-golick-685c88.netlify.app/bdk-cli/installation/ |
5f001e7
to
d5edcf7
Compare
d5edcf7
to
c56e219
Compare
Concept ACK. We'll be going through all docs once bdk-1.0.0 makes it to first beta release. This is a good thing to keep in mind for any docs where you don't want to run all the commands. |
i will leave this open - rebase as neccesary. |
taking a look at 'key' custom signet support and help output. Add a -n signet --challenge support? |
bdk-cli AFAIK only output valid keys for global signet currently. |
custom signet support ought to be on the v1 roadmap (non blocking but a nice to have) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c56e219.
@RandyMcMillan for some reason I can never rebase/force push on your branches I'm not sure why. This is my error: bitcoindevkit.org on 2021/850814/700297/f65aedb30/b21e96f20-docs/bdk-cli/installation.md [$] is 📦 v1.0.0 via v21.7.3
❯ git push --force
fatal: The upstream branch of your current branch does not match
the name of your current branch. To push to the upstream branch
on the remote, use
git push upstream HEAD:refs/pull/186/head
To push to the branch of the same name on the remote, use
git push upstream HEAD
To choose either option permanently, see push.default in 'git help config'.
To avoid automatically configuring upstream branches when their name
doesn't match the local branch, see option 'simple' of branch.autoSetupMerge
in 'git help config'. I tried both options above and they both don't work. I'm not 100% sure this would fix our issue, but would you mind opening PRs that use branches with more standard names, say in this case In any case I just opened a new PR with this commit. #200 |
Merged. |
No description provided.