Skip to content

docs/bdk-cli/installation.md:allow for individual copy/paste #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RandyMcMillan
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit c56e219
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/66886220c5b9b4000882614d
😎 Deploy Preview https://deploy-preview-186--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RandyMcMillan
Copy link
Contributor Author

RandyMcMillan commented Jul 5, 2024

this change allows each command to be copied individually.

https://deploy-preview-186--awesome-golick-685c88.netlify.app/bdk-cli/installation/

Screenshot 2024-07-05 at 12 06 07 PM

@RandyMcMillan RandyMcMillan force-pushed the 2021/850814/700297/f65aedb30/b21e96f20-docs/bdk-cli/installation.md branch from 5f001e7 to d5edcf7 Compare July 5, 2024 20:37
@RandyMcMillan RandyMcMillan force-pushed the 2021/850814/700297/f65aedb30/b21e96f20-docs/bdk-cli/installation.md branch from d5edcf7 to c56e219 Compare July 5, 2024 21:14
@notmandatory
Copy link
Member

Concept ACK. We'll be going through all docs once bdk-1.0.0 makes it to first beta release. This is a good thing to keep in mind for any docs where you don't want to run all the commands.

@RandyMcMillan
Copy link
Contributor Author

i will leave this open - rebase as neccesary.

@RandyMcMillan
Copy link
Contributor Author

taking a look at 'key' custom signet support and help output. Add a -n signet --challenge support?

@RandyMcMillan
Copy link
Contributor Author

bdk-cli AFAIK only output valid keys for global signet currently.

@RandyMcMillan
Copy link
Contributor Author

custom signet support ought to be on the v1 roadmap (non blocking but a nice to have)

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c56e219.

@thunderbiscuit
Copy link
Member

@RandyMcMillan for some reason I can never rebase/force push on your branches I'm not sure why.

This is my error:

bitcoindevkit.org on  2021/850814/700297/f65aedb30/b21e96f20-docs/bdk-cli/installation.md [$] is 📦 v1.0.0 via  v21.7.3
❯ git push --force
fatal: The upstream branch of your current branch does not match
the name of your current branch.  To push to the upstream branch
on the remote, use

    git push upstream HEAD:refs/pull/186/head

To push to the branch of the same name on the remote, use

    git push upstream HEAD

To choose either option permanently, see push.default in 'git help config'.

To avoid automatically configuring upstream branches when their name
doesn't match the local branch, see option 'simple' of branch.autoSetupMerge
in 'git help config'.

I tried both options above and they both don't work.

I'm not 100% sure this would fix our issue, but would you mind opening PRs that use branches with more standard names, say in this case docs/cli-fix?

In any case I just opened a new PR with this commit. #200

@thunderbiscuit
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants