feat(syncing): updated bdk_wallet to version 2.1.0
#122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated - `bdk_wallet` to version 2.1.0 - `bdk_bitcoind_rpc` to version 0.20.0
Updated - `bdk_wallet` to version 2.1.0 - `bdk_electrum` to version 0.23.1
Updated: - `bdk_wallet` to version 2.1.0 - `bdk_esplora` to version 0.22.1
Updated: - `bdk_wallet` to version 2.1.0 - `bdk_tokio` to version 0.13.1
There was a problem hiding this comment.
Awesome stuff! Lots of good stuff here. I added one little comment on the use of testnet 3.
I have a few changes I'd like to see added to this PR. Can you also update the starter-example, descriptors, persistence-memory, persistence-sqlite, and recovery-phrases examples?
| @@ -16,7 +16,7 @@ const INTERNAL_DESCRIPTOR: &str = "tr(tprv8ZgxMBicQKsPdrjwWCyXqqJ4YqcyG4DmKtjjsR | |||
|
|
|||
| fn main() -> Result<(), Error> { | |||
| let mut wallet: Wallet = Wallet::create(EXTERNAL_DESCRIPTOR, INTERNAL_DESCRIPTOR) | |||
| .network(Network::Signet) | |||
| .network(Network::Testnet) | |||
There was a problem hiding this comment.
We will keep using Signet for the examples if possible (if we used testnet it would be testnet 4 in any case).
But for this PR let's keep using Signet. You can hit the https://blockstream.info/signet/api/ esplora endpoint for this example.
| @@ -28,7 +28,7 @@ fn main() -> Result<(), Error> { | |||
| //--8<-- [start:client] | |||
| // Create the Esplora client | |||
| let client: esplora_client::BlockingClient = | |||
| Builder::new("http://signet.bitcoindevkit.net").build_blocking(); | |||
| Builder::new("https://blockstream.info/testnet/api/").build_blocking(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all syncing example to
bdk_wallet2.1.0 and latest clients version.