chore: Bump xcap to 0.7.0, let android can cargo build without extra patch #4344
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn111
changed the title
shawn111
changed the title
shawn111
commented
Aug 28, 2025
| @@ -1387,8 +1387,10 @@ impl DeveloperRouter { | |||
| ) | |||
| })?; | |||
|
|
|||
There was a problem hiding this comment.
xcap 0.0.14 -> xcap 0.7.0
- pub fn title(&self) -> &str {
- &self.impl_window.title
- }
- /// The window process id
- pub fn pid(&self) -> u32 {
- self.impl_window.pid
+ pub fn title(&self) -> XCapResult<String> {
+ self.impl_window.title()
+ }
|
goose core team works on refactor mcp #4297 |
DOsinga
approved these changes
Aug 28, 2025
| @@ -1559,7 +1561,7 @@ impl DeveloperRouter { | |||
|
|
|||
| let window = windows | |||
| .into_iter() | |||
| .find(|w| w.title() == window_title) | |||
| .find(|w| w.title().unwrap_or_default() == window_title) | |||
There was a problem hiding this comment.
why would we not have a window title?
There was a problem hiding this comment.
xcap 0.0.14 -> xcap 0.7.0
- pub fn title(&self) -> &str {
- &self.impl_window.title
- }
...
+ pub fn title(&self) -> XCapResult<String> {
+ self.impl_window.title()
+ }
There is for the change of xcap.
Or do you think is it good?
- bump `xcap` to 0.7.0 from 0.0.14 - improve some windows/wayland function - support android build - https://github.com/nashaofu/xcap/releases/tag/v0.7.0 - update Cross.toml - Added `pipewire-debian/pipewire-upstream` PPA - libegl1-mesa-dev, libgbm-dev, libpipewire-0.3-dev, libwayland-dev - updated w.title() calls to w.title().unwrap_or_default() Signed-off-by: Shawn Wang <shawn111@gmail.com>
|
rebase main & fix .github/workflows/ci.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Bump xcap to 0.7.0 and update Cross.toml:
xcapto 0.7.0 from 0.0.14- improve some windows/wayland function
- support android build
- https://github.com/nashaofu/xcap/releases/tag/v0.7.0
pipewire-debian/pipewire-upstreamPPAOnce, this PR merge, termux user can carge build goose without any patches.
There is the github action build from my repo:
https://github.com/shawn111/goose/releases/tag/canary
https://github.com/shawn111/goose/actions/runs/17299321930