-
Notifications
You must be signed in to change notification settings - Fork 152
Explore multi-verifier support #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
capossele
wants to merge
19
commits into
main
Choose a base branch
from
angelo/explore-multi-verifier-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mitmerkleandpriceandfulfill-to-contract
capossele
commented
May 20, 2025
bytes4 selector; | ||
/// @notice The address of the IRiscZeroVerifier contract. | ||
/// @dev If the address is set to zero, the default IRiscZeroVerifier is used. | ||
address verifier; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added if we want to give to the requestor full freedom to decide how its application seal should be verified.
Otherwise deploying via multi-router could also work
Base automatically changed from
angelo/bm-843-add-submitmerkleandpriceandfulfill-to-contract
to
main
May 28, 2025 22:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explores ideas for adding support for fulfilling requests with:
Related to BM-858