Production 2024-07-12_01 #2593
Merged
Production 2024-07-12_01 #2593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pavelbrm
commented
Jul 11, 2024
pavelbrm
commented
- chore: remove promotion.Service.hotWallet #2549
- fix: improve and simplify android receipt verification #2545
- Avoid fingerprint verification when checking IsUserKYC #2548
- Update actions, enable reproducible builds #2550
- refactor: remove unused cohort vars #2579
- chore: update dependencies #2583
- feat: reject linkings based on wallet geo country #2580
- build: use aws ecr public image for docker images #2584
- feat: add solana linking metrics #2586
- feat: add new products for ios nightly and beta #2592
promotion.Service.hotWallet is not used after the initialization. Thus the role of the relevant initialization code is reduced to verifying the grant wallet environment. But this is done in IsUserKYC in any case. So remove the relevant code.
* fix: improve and simplify android receipt verification * test: cover validateGoogleTime * chore: trigger CI
* chore: no fingerprint verification when checking uphold.IsUserKYC() is used only for online checks but not for payments. So skip certificate fingerprint checks to prevent outages when Uphold changes the certificate. Remove unused uphold.Wallet.Logger. Wallet methods always extract the logger from the passed Context. Plus remove from tests log level initialization. It was no-op as LogLevelCTXKey must be zerolog.Level, not a string. CLOSE: #2394 * fix: review comments
* chore: update dependencies * chore: update dependencies
clD11
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.