Run Kafka or API Independently #813
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
main.go
Outdated
| @@ -84,34 +80,35 @@ func main() { | |||
| // pprof attaches routes to default serve mux | |||
| // host:6061/debug/pprof/ | |||
| go func() { | |||
| log.Error().Err(http.ListenAndServe(addr, http.DefaultServeMux)) | |||
| logger.Error("listenandserve", slog.Any("error", http.ListenAndServe(addr, http.DefaultServeMux))) | |||
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] The profiling 'pprof' endpoint is automatically exposed on /debug/pprof. This could leak information about the server. Instead, use import "net/http/pprof". See https://www.farsightsecurity.com/blog/txt-record/go-remote-profiling-20161028/ for more information and mitigation.
Source: https://semgrep.dev/r/go.lang.security.audit.net.pprof.pprof-debug-exposure
Cc @thypon @kdenhartog
There was a problem hiding this comment.
as noted in other reviews, this service is behind the VPN so not a concern
kdenhartog
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, Kafka and the API run side-by-side due to deployment inconsistency which will soon be eliminated. Once complete, we can and should run only one or the other.