Skip to content

Conversation

napoly
Copy link
Member

@napoly napoly commented Jun 21, 2025

needs clean up.. should resolve the heat up issue as we don't need to wait and we can test the wallet upload workflow (branch from roslyn analyzer - needs rebase as well)

@napoly napoly requested a review from deverickapollo June 21, 2025 22:50
Copy link

codacy-production bot commented Jun 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+6.51% (target: -1.00%) 69.23%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2dddb62) 1088 547 50.28%
Head commit (4817343) 951 (-137) 540 (-7) 56.78% (+6.51%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#41) 39 27 69.23%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@napoly napoly marked this pull request as ready for review June 21, 2025 22:50
@napoly napoly force-pushed the remove-cheat-code-upload-wallet-manually branch from ad9aa2b to 6a46da3 Compare June 22, 2025 08:09
@plowsof
Copy link

plowsof commented Jun 22, 2025

just dropping some info reg the heat up issue:

  • during the UI step, the wallet rpc does not have an open wallet (but the test wallet exists)
  • the wallet must be opened.
  • after doing this, i changed the wallet is synced code to wait for the wallets height to == the daemons height. but originally the daemons height is 0 naturally so the wallet doesnt have to sync.
  • i sent a get_address req to pass to generate blocks (100)
  • looping until wallet height == daemon height, then the AllAvailable signal is sent correctly after synced = true
  • i have added a create_account call after the get_address to try the workflow again but its failing randomly still during build.
    logs of the above @ https://github.com/plowsof/btcpayserver-monero-plugin/actions/runs/15805097781/job/44548796393#step:9:2210
    the wallet rpc is available for requests (get_address .. create_account go through no problem)

a helpful piece of info would be an _logger "hello world" in the UI playright test file just to sanity check that this happens AFTER the above. because - starting wallet rpc up and immediately creating/opening a wallet makes everything work.

@plowsof
Copy link

plowsof commented Jun 22, 2025

confirming:

  • heat up issue is because the UI test file does not know about the wallet rpc's status / it does not wait for it to become available
  • the wallet will sync during the UI's test execution / in parallel , to explain the 'runs 2nd time' , and why creating a wallet/opening it at wallet-rpc start up in my PR 'fixes' ot (hides the problem)
  • UI must wait for IsAvailable

@napoly napoly force-pushed the remove-cheat-code-upload-wallet-manually branch from 15de443 to 69a7ac7 Compare June 23, 2025 16:51
@napoly napoly force-pushed the remove-cheat-code-upload-wallet-manually branch from eaa1000 to 6aa2412 Compare June 30, 2025 18:59
@napoly napoly changed the title Upload wallet manually and remove cashcow/cheatmode Generate wallet from private view key and remove cashcow/cheatmode Jun 30, 2025
@napoly napoly force-pushed the remove-cheat-code-upload-wallet-manually branch 5 times, most recently from e0edbb6 to 4817343 Compare July 1, 2025 14:31
@napoly
Copy link
Member Author

napoly commented Jul 2, 2025

should resolve #27

@napoly napoly force-pushed the remove-cheat-code-upload-wallet-manually branch from 4817343 to 52f25f9 Compare July 3, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants